-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add more 3.5 release notes #21527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more 3.5 release notes #21527
Conversation
b80138d
to
fad6ac4
Compare
fad6ac4
to
ff5a5f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modulo one plot suggestion.
Allow changing the vertical axis in 3d plots | ||
---------------------------------------------- | ||
|
||
`~mpl_toolkits.mplot3d.axes3d.Axes3D.view_init` now has the parameter | ||
*vertical_axis* which allows switching which axis is aligned vertically. | ||
|
||
.. plot:: | ||
|
||
x = np.array([0, 1, 2, 4]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A plot with more directional structure is more instructive, e.g.
phi = np.linspace(0, np.pi, 18)
x, y, z = np.hstack([
np.array([r*np.sin(phi), r*np.cos(phi), np.full_like(phi, 8-r)]) for r in range(8)])
fig, axs = plt.subplots(1, 3, figsize=(9, 3),
subplot_kw=dict(projection='3d'),
gridspec_kw=dict(wspace=0.5))
for vert_a, ax in zip(['z', 'y', 'x'], axs):
pc = ax.scatter(x, y, z, c=z)
ax.view_init(azim=30, elev=30, vertical_axis=vert_a)
ax.set(xlabel='x', ylabel='y', zlabel='z',
title=f'vertical_axis={vert_a!r}')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, but with some tweaks for the size; 9 inches is too wide for the docs page.
ff5a5f6
to
f8cfe23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one suggestion about the heading levels.
f8cfe23
to
13b4976
Compare
PR Summary
Adds some new features that were not previously documented, a few more images, and some development notes based on issues from the rc.
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).