Skip to content

Add more 3.5 release notes #21527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 10, 2021
Merged

Add more 3.5 release notes #21527

merged 7 commits into from
Nov 10, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Nov 2, 2021

PR Summary

Adds some new features that were not previously documented, a few more images, and some development notes based on issues from the rc.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic QuLogic added this to the v3.5.0 milestone Nov 2, 2021
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo one plot suggestion.

Allow changing the vertical axis in 3d plots
----------------------------------------------

`~mpl_toolkits.mplot3d.axes3d.Axes3D.view_init` now has the parameter
*vertical_axis* which allows switching which axis is aligned vertically.

.. plot::

x = np.array([0, 1, 2, 4])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A plot with more directional structure is more instructive, e.g.

    phi = np.linspace(0, np.pi, 18)
    x, y, z = np.hstack([
        np.array([r*np.sin(phi), r*np.cos(phi), np.full_like(phi, 8-r)]) for r in range(8)])
    
    
    fig, axs = plt.subplots(1, 3, figsize=(9, 3),
                            subplot_kw=dict(projection='3d'),
                            gridspec_kw=dict(wspace=0.5))
    for vert_a, ax in zip(['z', 'y', 'x'], axs):
        pc = ax.scatter(x, y, z, c=z)
        ax.view_init(azim=30, elev=30, vertical_axis=vert_a)
        ax.set(xlabel='x', ylabel='y', zlabel='z',
               title=f'vertical_axis={vert_a!r}')

grafik

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but with some tweaks for the size; 9 inches is too wide for the docs page.

Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one suggestion about the heading levels.

@QuLogic QuLogic merged commit 8960ff1 into matplotlib:main Nov 10, 2021
@QuLogic QuLogic deleted the more-3.5-docs branch November 10, 2021 04:07
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants