Skip to content

FIX: Make sure we do not over-write eps short cuts #21617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2021

Conversation

tacaswell
Copy link
Member

PR Summary

This tests that we have not re-defined a short-cut by checking that we do not
have two /name lines in the output file.

closes #21509

Co-authored-by: Antony Lee anntzer.lee@gmail.com

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

This tests that we have not re-defined a short-cut by checking that we do not
have two `/name` lines in the output file.

closes matplotlib#21509

Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
@tacaswell tacaswell added this to the v3.5.0 milestone Nov 12, 2021
@tacaswell
Copy link
Member Author

Because this is @anntzer 's patch and I opened the PR, @QuLogic can merge this on 1 review at his discretion.

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic QuLogic merged commit 6f1be17 into matplotlib:main Nov 13, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 13, 2021
QuLogic added a commit that referenced this pull request Nov 13, 2021
…617-on-v3.5.x

Backport PR #21617 on branch v3.5.x (FIX: Make sure we do not over-write eps short cuts)
@tacaswell tacaswell deleted the fix_eps_text branch November 14, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Text sometimes is missing when figure saved to EPS
2 participants