Fix plot directive with func calls #21661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66b1647 to
674c932
Compare
|
I ended up updating the existing tests which was by far the path of least resistence. One test change was needed because the output file names changed (because the function name is now in the output file name to prevent them from clobbering each other). |
This allows multiple functions from the same file to be called.
Also remove the () from the search so `plt.show(block=True)` will also be caught. The reason for this change is so that calling `plt.show()` inside of a function will not try to split the code into independently executed chunks.
We do not know where it is safe to split the code if we are going to later call a function for the generated namespace.
There are too many positional arguments and the names are subtly different.
674c932 to
1040fb2
Compare
1040fb2 to
dd38447
Compare
oscargus
reviewed
Dec 6, 2022
c49e2a5 to
8ecc8f2
Compare
timhoffm
reviewed
Dec 7, 2022
5721823 to
c2d1662
Compare
timhoffm
approved these changes
Dec 8, 2022
tacaswell
commented
Dec 8, 2022
c2d1662 to
f237d22
Compare
QuLogic
reviewed
Dec 17, 2022
Use `else` on for loop to be clearer about what break means.
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
efc9ebd to
947e10a
Compare
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
947e10a to
1411ba3
Compare
|
Doc failure is unrelated. |
QuLogic
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This will close #20656 .
I started but did not get through writing tests, I think I see a way to test just
render_figuresin a self-contained way, but wanted to push this up so it did not get lost.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).