FIX: put newline in matplotlibrc when setting default backend #21662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Nov 18, 2021
.github/workflows/tests.yml
Outdated
| @@ -225,6 +225,13 @@ jobs: | |||
| fi | |||
| fi | |||
|
|
|||
| cat <<EOT >> mplsetup.cfg | |||
| [rc_options] | |||
| ##backend=Agg | |||
There was a problem hiding this comment.
Does this do anything with the double comment?
There was a problem hiding this comment.
The goal was to not change the resultant matplotlibrc file from what it would be without this configuration. Without the bug fix this would have put the webagg.port on the same line so it would be missing and any import would fail..
There was a problem hiding this comment.
But the substitution doesn't care that this is double commented, it only inserts the value from here with a fixed key. And since this file is parsed by ConfigParser, it's not going to see this line at all, anyway.
There was a problem hiding this comment.
🤦🏻 🐑 I understand now.
There was a problem hiding this comment.
Third times the charm?
adamjstewart
approved these changes
Nov 18, 2021
9da439d to
e1a3266
Compare
e1a3266 to
e33baa8
Compare
jklymak
approved these changes
Nov 19, 2021
QuLogic
approved these changes
Nov 19, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 19, 2021
…etting default backend
QuLogic
added a commit
that referenced
this pull request
Nov 19, 2021
…662-on-v3.5.x Backport PR #21662 on branch v3.5.x (FIX: put newline in matplotlibrc when setting default backend)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21660
PR Summary
We are missing a new line when formatting the matplotlibrc
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).