overriding "__loader__" is ok #2170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oaded, so this is ok to override
|
Sprint! |
dmcdougall
added a commit
that referenced
this pull request
Jun 29, 2013
overriding "__loader__" is ok
dmcdougall
added a commit
that referenced
this pull request
Jul 17, 2013
overriding "__loader__" is ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite sure why this has started happening on Travis. On Python 3.3, the loader variable may be set on a module to indicate which module loader was used to load it. This is now showing up in the namespace of pyplot and then looks like an overridden builtin. This is an ok thing to do, this adds it to the list of things to ignore.