-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
FIX: deprecation of render keyword to do_3d_projection #21704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: deprecation of render keyword to do_3d_projection #21704
Conversation
Previously we both warned and required that renderer be an accepted argument.
super().__init__((0, 0), (0, 0), *args, **kwargs) | ||
self._verts3d = xs, ys, zs | ||
|
||
def do_3d_projection(self, render): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def do_3d_projection(self, render): | |
def do_3d_projection(self, renderer): |
Sorry, something went wrong.
All reactions
a = Arrow3D([0, 10], [0, 0], [0, 0], **arrow_prop_dict) | ||
ax.add_artist(a) | ||
|
||
with pytest.warns(MatplotlibDeprecationWarning): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should add a match
for the specific warning text you want here.
Sorry, something went wrong.
All reactions
Closing in favor of #21741 |
All reactions
Sorry, something went wrong.
i got this problem from the given code of the book math for programers by Paul Orland |
All reactions
Sorry, something went wrong.
Previously we both warned and required that renderer be an accepted argument.
After this is merged there should be a follow up to remove this entire code path.
PR Summary
Noticed this while debugging #21688
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).