Skip to content

FIX: align_x/ylabels #21762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2021
Merged

FIX: align_x/ylabels #21762

merged 1 commit into from
Nov 26, 2021

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Nov 26, 2021

PR Summary

As reported on gitter, if an axes does not have a subplotspec align_ylabels will fail:

fig, ax = plt.subplot_mosaic('AABB', figsize=(5, 2), constrained_layout=True)
pm = ax["A"].pcolormesh(np.random.randn(100, 100))
plt.colorbar(pm, ax=ax['A'], shrink=0.69, pad=0)
fig.align_ylabels()

This PR fixes this and tests the fix.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@jklymak jklymak added topic: geometry manager LayoutEngine, Constrained layout, Tight layout topic: ticks axis labels PR: bugfix Pull requests that fix identified bugs labels Nov 26, 2021
@jklymak jklymak added this to the v3.5.1 milestone Nov 26, 2021
@jklymak
Copy link
Member Author

jklymak commented Nov 26, 2021

I'm not sure this is really regression - it didn't work for 3.4.3, but its pretty straightforward, so maybe ok to go in 3.5.1

@QuLogic QuLogic merged commit f06543e into matplotlib:main Nov 26, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 26, 2021
QuLogic added a commit that referenced this pull request Nov 26, 2021
…762-on-v3.5.x

Backport PR #21762 on branch v3.5.x (FIX: align_x/ylabels)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bugfix Pull requests that fix identified bugs topic: geometry manager LayoutEngine, Constrained layout, Tight layout topic: ticks axis labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants