Use a fixture to get widget testing axes #21781

dstansby · 2021-11-28T15:34:29Z

Also define a generic noop function to use in the tests, which reduces more duplicated lines in the tests. Fixes #21774.

ericpre · 2022-01-09T12:44:10Z

@dstansby, other than the rebase, any reason to have this PR in draft?

dstansby · 2022-01-09T15:00:07Z

No, just needs a rebase and the PEP8 fix. Will convert to not-draft when I've done that.

dstansby added topic: widgets/UI Maintenance labels Nov 28, 2021

dstansby marked this pull request as draft November 28, 2021 15:59

story645 added the status: waiting for other PR label Nov 28, 2021

dstansby force-pushed the ax-fixture branch from ccac32e to cedcc39 Compare December 17, 2021 17:27

dstansby marked this pull request as ready for review December 17, 2021 17:27

dstansby added this to the v3.6.0 milestone Dec 17, 2021

dstansby marked this pull request as draft January 6, 2022 22:23

ericpre added status: needs rebase and removed status: waiting for other PR labels Jan 9, 2022

Use a fixture for widget test axes

6a5a169

dstansby force-pushed the ax-fixture branch from cedcc39 to 6a5a169 Compare January 9, 2022 16:15

dstansby removed the status: needs rebase label Jan 9, 2022

dstansby marked this pull request as ready for review January 9, 2022 16:15

ericpre approved these changes Jan 9, 2022

View reviewed changes

timhoffm approved these changes Jan 9, 2022

View reviewed changes

timhoffm merged commit 18b4b6e into matplotlib:main Jan 9, 2022

Provide feedback