-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Update setup.py #21819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup.py #21819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Thank you for working on this and sorry for the extraneous dependencies. Why do we need the dependency on This is breaking all of our tests because in Would it be possible to detect (or tell our selves) that we are building a wheel and extending rather than dropping this logic? |
@why do we need the dependency on wheel? I did run.: py -m pip wheel URL_2_matplotlib_repository#egg=... and it failed, with a error message that led me to believe that the wheels dependency is missing. Lacking knowledge of the internals, I expected it to be a good idea to add this dependancy. I believe that the lack of setuptools_scm is the problem for the test, and not the existance of wheel at setup time. I do believe it is hard to detect a test environment correctly, as matplotlib may end up to be suposed to run production mode in somebody elses test. i tried to add the setuptools_scm dependancy to the tox.ini file... |
this is taken care of elsewhere |
Thanks @franzhaas ! As you noted we went with an alternate solution for 3.5.1 that will fix the dependencies for the next set of wheels and will make setuptools-scm fully optional for 3.6. |
PR Summary
This adresses #21783
It is a very very small change, i droped the setuptools dependency for runtime and added a wheel dependency for setuptime.