Skip to content

Update setup.py #21819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update setup.py #21819

wants to merge 2 commits into from

Conversation

franzhaas
Copy link

PR Summary

This adresses #21783

It is a very very small change, i droped the setuptools dependency for runtime and added a wheel dependency for setuptime.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell tacaswell added this to the v3.5.1 milestone Nov 30, 2021
@tacaswell
Copy link
Member

Thank you for working on this and sorry for the extraneous dependencies.


Why do we need the dependency on wheel?

This is breaking all of our tests because in __init__.py we check if we are in a non-shallow git repo to make sure we get correct versions during development without having to re-build and we apparently have full git repos on some of the CI services (which is maybe something we should fix for other reasons, but I digress).

Would it be possible to detect (or tell our selves) that we are building a wheel and extending rather than dropping this logic?

@franzhaas
Copy link
Author

@why do we need the dependency on wheel?

I did run.:

py -m pip wheel URL_2_matplotlib_repository#egg=...

and it failed, with a error message that led me to believe that the wheels dependency is missing. Lacking knowledge of the internals, I expected it to be a good idea to add this dependancy.

I believe that the lack of setuptools_scm is the problem for the test, and not the existance of wheel at setup time.

I do believe it is hard to detect a test environment correctly, as matplotlib may end up to be suposed to run production mode in somebody elses test.

i tried to add the setuptools_scm dependancy to the tox.ini file...

@tacaswell
Copy link
Member

Please see the discussion in #21783 and #21820 as well.

I do not think we use the tox.ini anywhere in our CI process, I suspect it is out-of-date in otherways as well.

@franzhaas
Copy link
Author

this is taken care of elsewhere

@franzhaas franzhaas closed this Dec 3, 2021
@tacaswell
Copy link
Member

Thanks @franzhaas ! As you noted we went with an alternate solution for 3.5.1 that will fix the dependencies for the next set of wheels and will make setuptools-scm fully optional for 3.6.

@QuLogic QuLogic removed this from the v3.5.1 milestone Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants