Skip to content

Replace NSDictionary by switch-case. #21822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2021
Merged

Replace NSDictionary by switch-case. #21822

merged 1 commit into from
Dec 1, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 1, 2021

Both because we don't need an ObjC specific API here, and because the
old code layout caused way too long lines for my editor... (Also,
switch-case should be marginally faster, not that it should matter at
all here.)

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Replace NSDictionary by switch-case.
8773ff4 
Both because we don't need an ObjC specific API here, and because the
old code layout caused way too long lines for my editor... (Also,
switch-case should be marginally faster, not that it should matter at
all here.)
@QuLogic QuLogic added this to the v3.6.0 milestone Dec 1, 2021
greglucas
greglucas approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for waiting on this until after the other PR ;)

@greglucas greglucas merged commit 11243a9 into matplotlib:main Dec 1, 2021
@anntzer anntzer deleted the nsd branch December 1, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
Maintenance OS: Apple
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @greglucas