-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
axis3d.py : new inheritance and overriden methods for Yaxis class #21927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICS, using 'y' is the only difference to before. In that case, shouldn't we fix the original
Axis.get_tickspace
to useself._get_tick_label_size(self.axis_name)
(and defineaxis_name
on the 3d Axis classes)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the only difference to before is in fact not the use of 'y' but the multiplication by 3. We can see in the axis.py file that the method
get_tick_space
in the XAxis class has the linesize = self._get_tick_label_size('x') * 3
, whereas in the YAxis class the same method has the linesize = self._get_tick_label_size('y') * 2
The reason for this change in coefficient is the aspect of a 2D plot : it requires less space to write labels like this :
Than like this :
label label label (X labels)
However, in 3D plots the Y axis is like another X axis : hence the overriding of the method, even though it's just for one digit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. It seems we should turn the factor into a class variable then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're probably right, it would be more convenient. Oh and I also had a question : would you know why the
codecov/progect/tests
omitted thesrc
file in this PR ? I'm new to github and matplotlib, I don't really understand how all of it works.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to admit, that I don't understand Codecov either. It sometimes appears to do weird things.