Simplify canvas class control in FigureFrameWx. #21983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Dec 16, 2021
timhoffm
approved these changes
Dec 18, 2021
|
Anybody can merge after rebase. |
|
rebased. |
QuLogic
reviewed
Dec 21, 2021
Remember that the wx backends have a slightly different init order because the canvas cannot be instantiated *before* the containing window (a "frame" in wx parlance), so previously different wx backends implemented different frame subclasses so that each of them can instantiate different canvas subclasses. Instead of doing that (and having to assign them to the private `_frame_class` attribute, which is a problem e.g. for third-party backends such as mplcairo), directly pass the canvas class as a parameter to FigureFrameWx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remember that the wx backends have a slightly different init order
because the canvas cannot be instantiated before the containing window
(a "frame" in wx parlance), so previously different wx backends
implemented different frame subclasses so that each of them can
instantiate different canvas subclasses.
Instead of doing that (and having to assign them to the private
_frame_classattribute, which is a problem e.g. for third-partybackends such as mplcairo), directly pass the canvas class as a
parameter to FigureFrameWx.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).