Slightly tighten the _get_layout_cache_key API. #21985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_get_layout_cache_key is only ever called from _get_layout, which always passes a renderer arg which is never None (_get_layout calls `renderer.get_text_width_height_descent immediately after). So we can make the `renderer` arg required and not check for None. Also, get_unitless_position() can be directly used instead of unpacking it.
timhoffm
reviewed
Dec 16, 2021
timhoffm
approved these changes
Dec 18, 2021
QuLogic
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_get_layout_cache_key is only ever called from _get_layout, which always
passes a renderer arg which is never None (_get_layout calls
renderer.get_text_width_height_descentimmediately after). So we canmake the
rendererarg required and not check for None.Also, get_unitless_position() can be directly used instead of unpacking
it.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).