Use _make_classic_style_pseudo_toolbar more. #21992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90d3a92 to
09a4d75
Compare
QuLogic
reviewed
Dec 18, 2021
timhoffm
approved these changes
Dec 18, 2021
Looks like a few opportunities were missed in the conversion. The Tk _rubberband_rect has to move to the canvas instance (consistently with other backends), as hanging it off the temporary pseudo-toolbar won't work. Also fix the inheritance of ConfigureSubplotGTK, while we're at it, and delete the private _get_canvas method, which is not used anywhere in the codebase.
QuLogic
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a few opportunities were missed in the conversion.
The Tk _rubberband_rect has to move to the canvas instance (consistently
with other backends), as hanging it off the temporary pseudo-toolbar
won't work.
Also fix the inheritance of ConfigureSubplotGTK, while we're at it, and
delete the private _get_canvas method, which is not used anywhere in the
codebase.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).