Skip to content

See if pinning numpy to < 1.22 fixes tests #22076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

See if pinning numpy to < 1.22 fixes tests #22076

wants to merge 1 commit into from

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Jan 1, 2022

PR Summary

In the last couple of days a few of the tests have been failing on some builds. The test fails are:

FAILED lib/matplotlib/tests/test_axes.py::test_errorbar[png] - matplotlib.tes...
FAILED lib/matplotlib/tests/test_axes.py::test_errorbar[svg] - matplotlib.tes...
FAILED lib/matplotlib/tests/test_axes.py::test_errorbar[pdf] - matplotlib.tes...
FAILED lib/matplotlib/tests/test_streamplot.py::test_direction[png] - matplot...
FAILED lib/mpl_toolkits/tests/test_axisartist_grid_helper_curvelinear.py::test_axis_direction[png]
FAILED lib/mpl_toolkits/tests/test_mplot3d.py::test_trisurf3d[png] - matplotl...
FAILED lib/mpl_toolkits/tests/test_mplot3d.py::test_stem3d[png] - matplotlib....

Running a diff between installed packages on a succesful and failed run shows that the only packages that have changed are numpy-1.22.0, pikepdf-4.3.1, and pygments-2.11.1. I don't think it's a MPL commit causing the new test failures, so try pinning numpy to see if that's the cause.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@greglucas
Copy link
Contributor

CI pip installs MPL with --no-deps, so you'll have to pin it in the GitHub Actions file I think.

See here for some other discussion of checks I was trying before the release: #21634
I still can't reproduce these failures locally using the same numpy manylinux wheels that CI is using, so it is going to be tough to debug this.

@StefRe
Copy link
Contributor

StefRe commented Jan 2, 2022

I'm not sure it's just the numpy version alone, on #22063 (comment) I get the following results (I think it's the same for all the issues since yesterday):

Python  OS      numpy  result
3.7 min Ubuntu  1.17.0 pass
3.7     Ubuntu  1.21.5 pass
3.8     Ubuntu  1.22.0 fail
3.9     Ubuntu  1.22.0 fail
3.10    Ubuntu  1.22.0 pass
3.7     Windows 1.21.5 pass
3.8     Windows 1.22.0 pass
3.9     Windows 1.22.0 pass
3.7     mac     1.21.5 pass
3.8     mac	1.22.0 pass
3.9     mac	1.22.0 pass

@scottshambaugh scottshambaugh mentioned this pull request Jan 2, 2022
Merged
5 tasks
@dstansby dstansby force-pushed the numpy-pin branch 2 times, most recently from 8daa54a to d4bae12 Compare January 3, 2022 16:24
@dstansby dstansby marked this pull request as draft January 3, 2022 17:02
@timhoffm timhoffm mentioned this pull request Jan 3, 2022
Merged
1 task
@dstansby
Copy link
Member Author

dstansby commented Jan 4, 2022

Replaced by #22099

@dstansby dstansby closed this Jan 4, 2022
@dstansby dstansby deleted the numpy-pin branch January 4, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstansby @greglucas @StefRe