Expire colorbar-related deprecations. #22081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Jan 2, 2022
jklymak
reviewed
Jan 3, 2022
| @@ -0,0 +1,11 @@ | |||
| `colorbar`` defaults to stealing space from the mappable's axes rather than the current axes | |||
There was a problem hiding this comment.
Suggested change
| `colorbar`` defaults to stealing space from the mappable's axes rather than the current axes | |
| colorbar defaults to stealing space from the mappable's axes rather than the current axes |
This was failing the doc build, but I also think @QuLogic prefers we dont' add styling in the headlines?
There was a problem hiding this comment.
Thanks for catching that.
There was a problem hiding this comment.
Styling is okay, generally, but not cross-references.
QuLogic
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).