Skip to content

Clean up 3d plot box_aspect zooming #22084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2022
Merged

Clean up 3d plot box_aspect zooming #22084

merged 1 commit into from
Jan 11, 2022

Conversation

scottshambaugh
Copy link
Contributor

@scottshambaugh scottshambaugh commented Jan 2, 2022 •
edited
Loading

PR Summary

Expose 3D plot zoom as a parameter, do input checking, clean up docstrings.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@scottshambaugh scottshambaugh force-pushed the 3d_plot_zoom branch 5 times, most recently from b5fc59d to 808daf9 Compare January 2, 2022 20:51
@scottshambaugh scottshambaugh force-pushed the 3d_plot_zoom branch 3 times, most recently from 90bce73 to a607764 Compare January 4, 2022 20:34
timhoffm
timhoffm reviewed Jan 4, 2022
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for taking it slow and thinking possible API changes through thoroughly before taking action.

@scottshambaugh scottshambaugh force-pushed the 3d_plot_zoom branch 3 times, most recently from baef276 to e69051e Compare January 6, 2022 19:50
@scottshambaugh
Clean up 3d plot box_aspect zooming
b1737e0 
linting

Cleanup

Make zoom and dist private attrs

Deprecate Axes3D.dist

Deprecate Axes3D.dist
timhoffm
timhoffm approved these changes Jan 6, 2022
View reviewed changes
@timhoffm timhoffm added this to the v3.6.0 milestone Jan 6, 2022
@QuLogic QuLogic merged commit c2d9c90 into matplotlib:main Jan 11, 2022
@scottshambaugh scottshambaugh deleted the 3d_plot_zoom branch January 11, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: mplot3d
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@scottshambaugh @QuLogic @timhoffm @dstansby