Skip to content

Expire axes_grid1/axisartist deprecations. #22098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2022
Merged

Expire axes_grid1/axisartist deprecations. #22098

merged 1 commit into from
Jan 11, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 3, 2022

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer anntzer added this to the v3.6.0 milestone Jan 3, 2022
@timhoffm
Copy link
Member

timhoffm commented Jan 4, 2022

There's still an error in the docs build

Traceback (most recent call last):
  File "/home/circleci/project/examples/axisartist/demo_parasite_axes.py", line 20, in <module>
    from mpl_toolkits.axisartist.parasite_axes import HostAxes, ParasiteAxes
  File "/home/circleci/project/lib/mpl_toolkits/axisartist/parasite_axes.py", line 2, in <module>
    from mpl_toolkits.axes_grid1.parasite_axes import (
ImportError: cannot import name 'parasite_axes_auxtrans_class_factory' from 'mpl_toolkits.axes_grid1.parasite_axes' (/home/circleci/project/lib/mpl_toolkits/axes_grid1/parasite_axes.py)

@anntzer
Copy link
Contributor Author

anntzer commented Jan 4, 2022

Thanks, fixed.

@QuLogic QuLogic merged commit 5398657 into matplotlib:main Jan 11, 2022
@anntzer anntzer deleted the mpltk36 branch January 11, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
API: changes Maintenance topic: mpl_toolkit
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @QuLogic