Hint at draw_without_rendering() in Text.get_window_extent #22122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
commented
Jan 6, 2022
| @@ -882,8 +882,9 @@ def get_window_extent(self, renderer=None, dpi=None): | |||
| A renderer is needed to compute the bounding box. If the artist | |||
| has already been drawn, the renderer is cached; thus, it is only | |||
| necessary to pass this argument when calling `get_window_extent` | |||
| before the first `draw`. In practice, it is usually easier to | |||
| trigger a draw first (e.g. by saving the figure). | |||
| before the first draw. In practice, it is usually easier to | |||
There was a problem hiding this comment.
The draw link would go to Text.draw which is more or less an internal API and not helpful here (at worst the user might try and call that). It's better to not link to anything here.
612a21c to
9477aae
Compare
timhoffm
commented
Jan 6, 2022
Comment on lines
+886
to
+887
| trigger a draw first, e.g. by calling | ||
| `~.Figure.draw_without_rendering` or ``plt.show()``. |
There was a problem hiding this comment.
Saving is usually not a good way to trigger a draw in this case. You'll likely want to modify the figure somehow based on the extent.
There was a problem hiding this comment.
I'm 50/50 about including plt.show() as
plt.ion()
for j in range(5):
fig, ax = plt.subplots()
plt.show()
sleep(5)will not spin the GUI event loop (and hence in some cases not get the actual render to happen) until after the loop is done.
There was a problem hiding this comment.
OK, but 99.999% of cases, a draw will occur!
tacaswell
approved these changes
Jan 6, 2022
jklymak
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.