TST: Increase fp tolerances for some images #22132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
d302dbe to
4a59849
Compare
jklymak
approved these changes
Jan 6, 2022
This is for floating point errors that crept in with AVX512 instruction sets on some CI architectures.
4a59849 to
3438672
Compare
tacaswell
approved these changes
Jan 6, 2022
3 tasks
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 6, 2022
QuLogic
added a commit
that referenced
this pull request
Jan 7, 2022
…132-on-v3.5.x Backport PR #22132 on branch v3.5.x (TST: Increase fp tolerances for some images)
2 tasks
melissawm
pushed a commit
to melissawm/matplotlib
that referenced
this pull request
Dec 19, 2022
This is similar to matplotlib#22132 in that NumPy has added more code paths that now take advantage of AVX512 optimizations and causes slight variations in results. Fixes matplotlib#24060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This reverts PR #22099 and instead bumps the tolerances of some of the image tests. This is due to the AVX512 instruction set being used on some CI runners.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).