Fix loading user-defined icons for Qt plot window #22135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This affects Tk as well, I think. |
|
Yes, here: matplotlib/lib/matplotlib/backends/_backend_tk.py Lines 647 to 649 in 80d4e23 |
|
I've copied the changes to the Tk backend in #22147 |
QuLogic
reviewed
Jan 7, 2022
dab05a6 to
1eb73ab
Compare
QuLogic
approved these changes
Jan 7, 2022
daniilS
suggested changes
Jan 8, 2022
1eb73ab to
eaaee4e
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 8, 2022
QuLogic
added a commit
that referenced
this pull request
Jan 8, 2022
…135-on-v3.5.x Backport PR #22135 on branch v3.5.x (Fix loading user-defined icons for Qt plot window)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #22131.
I'll refrain from writing a test for this because that would be quite cumbersome. One can manually test the correctness be deleting one of the
_largeicons. Then the plot window falls back to the low-res version of that icon.It's also unlike to break again, because the comment should make future authors aware that we have to have the fall back for user icons.