Skip to content

FIX: width/height were reversed in macosx rectangle creation #22139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

greglucas
Copy link
Contributor

PR Summary

This was missed in the review of #22109. Without this on a hidpi monitor there is a blank bar on the top of the figure, previously I was testing on a non hi-dpi monitor so apparently that wasn't a big enough canvas to create the blank bar).

Here is the method definition: https://developer.apple.com/documentation/foundation/1391329-nsmakerect

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@greglucas greglucas added this to the v3.6.0 milestone Jan 7, 2022
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also looked at the other calls.

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops.

@anntzer anntzer merged commit 80d4e23 into matplotlib:main Jan 7, 2022
@greglucas greglucas deleted the macosx-wh branch January 7, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants