Make Tk windows use the same icon as other backends #22145
Conversation
|
It looks like we switch from a gif to a ppm in 2015. Is the important change here going from ppm -> png or just that the png icon is higher resolution (and has alpha)? |
|
@tacaswell The change is going from ppm to png, as all the other backends use the auto-generated png icons, but Tk had its own file that looks different. I reckon it's best to minimise backend differences, same logic as #18889. Alpha channel support is also an advantage. |
|
Sorry, my last comment was very confusing 🐑 I think the real improvement here is to use a better icon (which matches the rest of the backends). The fact that the old one was ppm and the new one is png is not really relevant (as if they were called Or is there something about ppm files (that I do not know/understand) that makes the png version of the icon better? |
|
Ah right, I get you. Yes, the change is going from v0 to v1, the change to png is just because that's how the v1 icon is stored and there's no need for the unique ppm file any more now that PIL is a dependency. I'll change the title. |
|
Thanks @daniilS! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
|
Thanks @QuLogic! I thought the Tk backend could use some love so have been going through all the open "GUI/tk" issues one by one 😅 |
PR Summary
This makes the icons look better, and consistent with the other backends. See below for examples on Windows. The only icon that doesn't quite look right is the titlebar icon at 100% scaling. If a 16x16 image is supplied, Windows will preferentially use that, which looks better, but then it will also use it at other scaling factors, making them blurry. I think this is the best the icons can look with the current version of Tk.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).