Give the Tk toolbar buttons a flat look #22174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Jan 9, 2022
QuLogic
reviewed
Jan 19, 2022
| b = tk.Button(master=self, text=text, command=command) | ||
| b = tk.Button( | ||
| master=self, text=text, command=command, | ||
| relief="flat", overrelief="groove", borderwidth=1, |
There was a problem hiding this comment.
Is the border width inside or outside the button? Just wondering if the size we allocate is consistent on HiDPI screens?
There was a problem hiding this comment.
It's outside of the button, and the default width seems to be 2, so space shouldn't be an issue.
There was a problem hiding this comment.
I'm more concerned about the height of the toolbar than the width of the border itself.
There was a problem hiding this comment.
The toolbar height is set to the height of two text lines here, which on all platforms I've tried is bigger than the size of the buttons, so the buttons becoming 2px smaller shouldn't affect the height of the toolbar.
QuLogic
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This changes the parameters of the buttons in the Tk navigation toolbar to give them a flat look (with an outline showing when the mouse is over the button), similar to the Qt backend. For comparison:
Old:
New: