Skip to content

Backport PR #22179 on branch v3.5.x (FIX: macosx check case-insensitive app name) #22195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2022
Merged

Backport PR #22179 on branch v3.5.x (FIX: macosx check case-insensitive app name) #22195

merged 1 commit into from
Jan 11, 2022
+2 −2

Conversation

greglucas
Copy link
Contributor

@greglucas greglucas commented Jan 11, 2022 •
edited by QuLogic
Loading

PR Summary

Manual backport of #22179

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic QuLogic closed this Jan 11, 2022
@QuLogic QuLogic reopened this Jan 11, 2022
@QuLogic QuLogic added this to the v3.5.2 milestone Jan 11, 2022
@QuLogic
Copy link
Member

QuLogic commented Jan 11, 2022

Oh right, the fix to the documentation merge won't appear by re-opening because it's the merge itself that is broken. This doesn't touch docs, so I'll just merge without them,

@QuLogic QuLogic merged commit 76156a9 into matplotlib:v3.5.x Jan 11, 2022
@QuLogic
Copy link
Member

QuLogic commented Jan 14, 2022 •
edited
Loading

This broke wheel builds, as we target 10.9 for the 3.5.x branch:

clang++ -bundle -undefined dynamic_lookup -g -arch x86_64 build/temp.macosx-10.9-x86_64-3.10/matplotlib._ttconv/extern/ttconv/pprdrv_tt.o build/temp.macosx-10.9-x86_64-3.10/matplotlib._ttconv/extern/ttconv/pprdrv_tt2.o build/temp.macosx-10.9-x86_64-3.10/matplotlib._ttconv/extern/ttconv/ttutil.o build/temp.macosx-10.9-x86_64-3.10/matplotlib._ttconv/src/_ttconv.o -o build/lib.macosx-10.9-x86_64-3.10/matplotlib/_ttconv.cpython-310-darwin.so
building 'matplotlib.backends._macosx' extension
creating build/temp.macosx-10.9-x86_64-3.10/matplotlib.backends._macosx
creating build/temp.macosx-10.9-x86_64-3.10/matplotlib.backends._macosx/src
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -g -arch x86_64 -I/Library/Frameworks/Python.framework/Versions/3.10/include/python3.10 -c src/_macosx.m -o build/temp.macosx-10.9-x86_64-3.10/matplotlib.backends._macosx/src/_macosx.o -Werror=unguarded-availability -fvisibility=hidden -flto
src/_macosx.m:1380:13: error: 'localizedCaseInsensitiveContainsString:' is only available on macOS 10.10 or newer [-Werror,-Wunguarded-availability]
            localizedCaseInsensitiveContainsString:@"python"])
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSString.h:162:1: note: 'localizedCaseInsensitiveContainsString:' has been marked as being introduced in macOS 10.10 here, but the deployment target is macOS 10.9.0
- (BOOL)localizedCaseInsensitiveContainsString:(NSString *)str API_AVAILABLE(macos(10.10), ios(8.0), watchos(2.0), tvos(9.0));
^
src/_macosx.m:1380:13: note: enclose 'localizedCaseInsensitiveContainsString:' in an @available check to silence this warning
            localizedCaseInsensitiveContainsString:@"python"])
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
error: command '/usr/bin/clang' failed with exit code 1

@dstansby dstansby mentioned this pull request Jan 15, 2022
Merged
@greglucas greglucas deleted the auto-backport-of-pr-22179-on-v3.5.x branch January 21, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI: MacOSX
Projects
None yet
Milestone
v3.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@greglucas @QuLogic @timhoffm