Try PySide then PyQt4 for Qt4 examples. #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the correct connect method for PySide. This should make the examples work with both PyQt4 and PySide (I can only test the later)
|
It's not quite true that matplotlib always prefers PySide over PyQt4. It uses first the These should do something like and then act accordingly. |
Thanks to Michael Droettboom (matplotlib#2221 (comment))
|
Ahh thanks Michael. I have updated my pull request. |
|
Looks good to me. Thanks. |
mdboom
added a commit
that referenced
this pull request
Jul 17, 2013
Try PySide then PyQt4 for Qt4 examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct connect method for PySide.
This should make the examples work with both PyQt4 and PySide (I can only test the later)
Note that when I tested it with PySide the animation example would update the graph but not the frame around it.
I also only tested it on OSX. I only tested it with PySide because MPL picks PySide in preference when it and PyQt4 are installed.