Partial fix for grid alpha #22234
Merged
Partial fix for grid alpha #22234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
commented
Jan 15, 2022
| @@ -1413,7 +1419,7 @@ def grid(self, visible=None, which='major', **kwargs): | |||
| visible = True | |||
| which = which.lower() | |||
| _api.check_in_list(['major', 'minor', 'both'], which=which) | |||
| gridkw = {'grid_' + item[0]: item[1] for item in kwargs.items()} | |||
| gridkw = {f'grid_{name}': value for name, value in kwargs.items()} | |||
There was a problem hiding this comment.
No functional change, only better formatting for readability.
jklymak
reviewed
Jan 20, 2022
6c00098 to
a3f0abc
Compare
jklymak
approved these changes
Feb 1, 2022
QuLogic
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Partial fix for #22231.
This is clearly a logic error fix, see comment in code. Unfortunately, there is a much larger underlying problem, which is why this PR alone won't fix the problem and I cannot add tests.
The underlying problem lies in the arcane tick mechanism; roughly: via the
_LazyTickLists we generatemajorTicks[0], which gets not parameters and thus resolvesrcParams['grid.alpha']to a float. OTOH new ticks are created by copying properties from existing ticks. Even though this PR fixes the tick gridline initialization to respect a color alpha,_copy_tick_props()overwrites the gridline alpha afterwards.I've spent a couple of hours digging this out and trying to find a proper fix. My time budget on this issue is exhausted. You may merge this PR as a partial fix if you think it's reasonable; or you may take it as a basis for digging into the complete fix.