Add minimum macosx version #22240
Add minimum macosx version #22240
Conversation
|
Probably should set the deployment target in cibuildwheel. |
setupext.py
Outdated
| ext.extra_compile_args.extend(['-Werror', '-mmacosx-version-min=10.12']) | ||
| ext.extra_link_args.extend(['-framework', 'Cocoa', '-mmacosx-version-min=10.12']) |
There was a problem hiding this comment.
Do we actually need this? I think the environment variable MACOSX_DEPLOYMENT_TARGET should be used instead, which you already have defined above. This says they are synonymous, and more importantly that this flag is actually a gcc flag that clang supports for now, but potentially not into the future.
https://stackoverflow.com/questions/25352389/what-is-the-difference-between-macosx-deployment-target-and-mmacosx-version-min
There was a problem hiding this comment.
I've removed this change from my latest commit to see if it's needed.
There was a problem hiding this comment.
It turns out we didn't need this - builds seem to be fine with just the environment variable set.
191cf36 to
152e9c7
Compare
This is a draft to see if we can specify the macosx minimum version to be higher to fix wheel building. See #22179 (comment) for details on why the wheels are currently failing.
As per #18128 (comment) and other discussion on that issue I've set the minimum version to 10.12.
Fixes #18066