Skip to content

Respect position and group argument in Tk toolmanager add_toolitem #22290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

daniilS
Copy link
Contributor

@daniilS daniilS commented Jan 22, 2022

PR Summary

Closes #20130. This makes the toolmanager_sgskip.py example behave correctly in the Tk backend.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems about right, and does fix the issue.

@anntzer anntzer added GUI: tk MEP: MEP22 tool manager labels Jan 22, 2022
@timhoffm timhoffm added this to the v3.5.2 milestone Jan 25, 2022
@timhoffm timhoffm merged commit 0f9bab8 into matplotlib:main Jan 25, 2022
@timhoffm
Copy link
Member

Thanks!

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 25, 2022
QuLogic added a commit that referenced this pull request Jan 27, 2022
…290-on-v3.5.x

Backport PR #22290 on branch v3.5.x (Respect `position` and `group` argument in Tk toolmanager add_toolitem)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tk toolmanager add_toolitem fails to add tool to group other than the last one
3 participants