MNT: Deprecate cbook.maxdict #22299
Closed
MNT: Deprecate cbook.maxdict #22299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was used in one place in the library and there is now a standard library lru_cache that we can take advantage of instead.
9ffcb45 to
c4f3dc3
Compare
QuLogic
reviewed
Jan 25, 2022
Comment on lines
+299
to
+300
| @functools.lru_cache(maxsize=50) | ||
| def _get_layout_cache(self, key, renderer): |
6 tasks
|
Closing in favor of #22323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
It was used in one place in the library and there is now a standard library lru_cache that we can take advantage of instead. This adds a new private method that is called after the key is created.
Closes #22278
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).