Skip to content

wx.App() should be init'ed in new_figure_manager_given_figure #22339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 27, 2022

... not in new_figure_manager. Otherwise, unpickling a figure fails
with wx if no figure was created previously:

$ MPLBACKEND=wxagg python -c 'from pylab import *; plot(); import pickle; pickle.dump(plt.gcf(), open("/tmp/pkl", "wb"))'
$ MPLBACKEND=wxagg python -c 'import pickle; pickle.load(open("/tmp/pkl", "rb"))'

fails with "wx._core.PyNoAppError: The wx.App object must be created first!"

Because new_figure_manager calls new_figure_manager_given_figure (see
note in backend_template), it doesn't need to copy the instantiation.

Also note that backend_tk was already doing the init in
new_figure_manager_given_figure.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

... not in new_figure_manager.  Otherwise, unpickling a figure fails
with wx if no figure was created previously:
```
$ MPLBACKEND=wxagg python -c 'from pylab import *; plot(); import pickle; pickle.dump(plt.gcf(), open("/tmp/pkl", "wb"))'
$ MPLBACKEND=wxagg python -c 'import pickle; pickle.load(open("/tmp/pkl", "rb"))'
```
fails with "wx._core.PyNoAppError: The wx.App object must be created first!"

Because new_figure_manager calls new_figure_manager_given_figure (see
note in backend_template), it doesn't need to copy the instantiation.

Also note that backend_tk was already doing the init in
new_figure_manager_given_figure.
@tacaswell tacaswell added this to the v3.6.0 milestone Jan 28, 2022
@timhoffm timhoffm merged commit c6bad8c into matplotlib:main Jan 28, 2022
@anntzer anntzer deleted the wxapp branch January 28, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants