Skip to content

Pin coverage to fix CI #22398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Pin coverage to fix CI #22398

merged 1 commit into from
Feb 7, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 4, 2022

PR Summary

The newly released 6.3.1 is still sporadically failing from nedbat/coveragepy#1310

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

The newly released 6.3.1 is still sporadically failing from
nedbat/coveragepy#1310
@QuLogic QuLogic added this to the v3.5.2 milestone Feb 4, 2022
@QuLogic
Copy link
Member Author

QuLogic commented Feb 5, 2022

For Azure, it looks like the macOS images were updated from 20220124.1 to 20220201.2. I'm not seeing anything specifically about Ghostscript in the changes. Ghostscript seems to be installed via Homebrew and hasn't changed versions there, but possibly some of its dependencies have.

@QuLogic
Copy link
Member Author

QuLogic commented Feb 5, 2022

Based on the output from Azure, it appears that Ghostscript is compressing some streams with LZW in binary. This gets somewhat mangled by outputting to StringIO and then trying to encode it to compare against the BytesIO result. I'm not sure we really should be supporting StringIO, or at least disable compression if so.

@anntzer
Copy link
Contributor

anntzer commented Feb 5, 2022

I think I agree that saving distiller output to text streams does not make sense (as the postscript standard explicitly allows arbitrary binary sequences (section 3.14 "Binary encoding details"), we just don't output them ourselves. I guess the most backcompatible fix is the one you suggest (to disable distillers when outputting to text, perhaps logging a warning in that case).

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval limited to the coverage part.

@tacaswell
Copy link
Member

I generally dislike hard upper pins, but we will want to do a hard-pin on the 3.5.x branch anyway and it sounds like we are not the only people with this issue.

@tacaswell
Copy link
Member

I'm going to merge this over the GS related failures.

@tacaswell tacaswell merged commit 88fc75c into matplotlib:main Feb 7, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 7, 2022
@QuLogic QuLogic deleted the pin-coverage branch February 7, 2022 22:34
@QuLogic
Copy link
Member Author

QuLogic commented Feb 7, 2022

I generally dislike hard upper pins, but we will want to do a hard-pin on the 3.5.x branch anyway and it sounds like we are not the only people with this issue.

I'm following the upstream issue so I can test unpin when it's fixed,

timhoffm added a commit that referenced this pull request Feb 8, 2022
…398-on-v3.5.x

Backport PR #22398 on branch v3.5.x (Pin coverage to fix CI)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants