allow setting collection offsets to empty #22408
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Feb 6, 2022
ianhi
commented
Feb 7, 2022
| modified = mcollections.Collection( | ||
| offsets=np.column_stack([[0, 1], [0, 1]]) | ||
| ) | ||
| modified.set_offsets([[], []]) |
There was a problem hiding this comment.
I think that this should actually be column_stack and I should get rid of the transpose in the set method. Most usage will be with column_stack i suspect.
There was a problem hiding this comment.
Please check what other set_offsets methods do. We should aim for consistency.
tacaswell
requested changes
Mar 29, 2022
| (np.asarray(self.convert_xunits(offsets[:, 0]), 'float'), | ||
| np.asarray(self.convert_yunits(offsets[:, 1]), 'float'))) | ||
|
|
||
| if offsets.shape == (2, 0): |
There was a problem hiding this comment.
Suggested change
| if offsets.shape == (2, 0): | |
| if offsets.shape == (0, 2): |
Which will require some changes to the tests.
The docs say(N, 2) so this should be the degenerate case of ((N, 2), .., (2, 2), (1, 2), (0, 2)) (the (2,) case is a special case for spelling (1, 2)).
|
Anyone can dismiss my review |
|
Fell free to move out of draft... |
|
Looking at this again, I think my comment is still valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes: #22401
Importantly allows this:
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).