-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Update Scipy intersphinx inventory link #22431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in scipy/scipy#15545 the object inventory has moved. Though there's a redirect, it has paths like `reference/..` which doubles the `reference` in the URL.
According to its docs, there's no need for any additional entries in `reference_url` if intersphinx is being used.
7 tasks
power cycled to re-build with fixed docs. |
timhoffm
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failures are unrelated to the PR.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 9, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 9, 2022
timhoffm
added a commit
that referenced
this pull request
Feb 9, 2022
…431-on-v3.5.1-doc Backport PR #22431 on branch v3.5.1-doc (Update Scipy intersphinx inventory link)
QuLogic
added a commit
that referenced
this pull request
Feb 9, 2022
…431-on-v3.5.x Backport PR #22431 on branch v3.5.x (Update Scipy intersphinx inventory link)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As noted in scipy/scipy#15545 the object inventory has moved. Though there's a redirect, it has paths like
reference/..
which doubles thereference
in the URL.Additionally, we don't need explicit entries in
reference_url
because sphinx-gallery will get them from the intersphinx config.PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).