Turn _mathtext.ship into a plain function. #22468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Feb 13, 2022
oscargus
reviewed
Feb 17, 2022
oscargus
reviewed
Feb 17, 2022
|
Just some minor doubts to possible consider, but I also found this line that probably should be changed: matplotlib/lib/matplotlib/_mathtext.py Line 914 in 593ff96 |
oscargus
reviewed
Feb 17, 2022
|
Edit: I also made |
Making it a plain function with two nested mutually recursive functions, instead of a singleton object with methods, makes ship() thread-safe at no cost (otherwise, two threads calling ship() at the same time would overwrite each other's instance variables).
QuLogic
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Making it a plain function with two nested mutually recursive functions,
instead of a singleton object with methods, makes ship() thread-safe at
no cost (otherwise, two threads calling ship() at the same time would
overwrite each other's instance variables).
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).