Skip to content

axes_grid1: ImageGrid respect the aspect ratio of axes. #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2014

Conversation

leejjoon
Copy link
Contributor

I thought I committed this change a while ago. There is a reference to my commit

f6b344e

but somehow this is not shown in the commit history of the master branch (nor the release branch).

This PR is to resolve #955, which I closed sometime ago since I thought I made this commit.
I am making this PR against the v1.3.x branch as this is more like a bug fix, but if others think this is not appropriate, I will rebase and make another PR.

@dmcdougall
Copy link
Member

@leejjoon I see this commit in the output of git log. What do you mean by, "the commit is not shown in the commit history"?

@leejjoon
Copy link
Contributor Author

Hmm, that's weird.

Here is a commit history of "axes_grid.py" and the related commit is not shown.

https://github.com/matplotlib/matplotlib/commits/master/lib/mpl_toolkits/axes_grid1/axes_grid.py

pelson added a commit that referenced this pull request Jan 9, 2014
axes_grid1: ImageGrid respect the aspect ratio of axes.
@pelson pelson merged commit ecdcc74 into matplotlib:v1.3.x Jan 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants