FIX: make the show API on webagg consistent with others #22499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
QuLogic
approved these changes
Feb 19, 2022
timhoffm
approved these changes
Feb 19, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 19, 2022
…tent with others
|
Should matplotlib/lib/matplotlib/backend_bases.py Lines 3498 to 3501 in 62dfcfd block make any sense in a webagg context? (If yes, then adding it as noop seems wrong; if not, ignoring it seems OK.)
|
timhoffm
added a commit
that referenced
this pull request
Feb 19, 2022
…499-on-v3.5.x Backport PR #22499 on branch v3.5.x (FIX: make the show API on webagg consistent with others)
|
Should a non-None block value in show warn or raise if it has no effect? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds a keyword-only block kwarg to the show method on webagg (like all other backends)
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).