Skip to content

Deprecate backend_qt.qApp. #22503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Deprecate backend_qt.qApp. #22503

merged 2 commits into from
Mar 22, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 19, 2022

This global has subtly different semantics from
QtWidgets.QApplication.instance() (it is only updated when the private
_create_qApp is called), and therefore seems not worth exposing.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer anntzer added this to the v3.6.0 milestone Feb 19, 2022
@oscargus oscargus mentioned this pull request Feb 19, 2022
6 tasks
@anntzer anntzer mentioned this pull request Feb 24, 2022
6 tasks
This global has subtly different semantics from
QtWidgets.QApplication.instance() (it is only updated when the private
_create_qApp is called), and therefore seems not worth exposing.
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not want to merge because I pushed a commit of tests.

@timhoffm timhoffm merged commit e6b7908 into matplotlib:main Mar 22, 2022
@anntzer anntzer deleted the uq branch March 22, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants