Simplifications to ToolManager.{add,remove}_tool. #22509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the addition side, inline ToolManager._tool_added_event. It's used at a single place, and other events emitted by ToolManager are not split out into their own helper methods. On the removal side, deprecate the Tool.destroy handle: it's unused, and if a tool really wants to know when it's getting removed, it can just connect to its own tool_removed_event, which can also be used by other callers.
oscargus
approved these changes
Feb 22, 2022
greglucas
approved these changes
Mar 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the addition side, inline ToolManager._tool_added_event. It's used
at a single place, and other events emitted by ToolManager are not split
out into their own helper methods.
On the removal side, deprecate the Tool.destroy handle: it's unused, and
if a tool really wants to know when it's getting removed, it can just
connect to its own tool_removed_event, which can also be used by other
callers.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).