Skip to content

fixing 3d ticks direction #22517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
cb8350b
fixing 3d ticks direction
peta78 Feb 21, 2022
fa02b4b
shortening lines
peta78 Feb 21, 2022
73c454c
update of code
peta78 Feb 24, 2022
a902370
merge
peta78 Feb 24, 2022
b3eeffc
removing spaces - not sure how they got there
peta78 Feb 24, 2022
dce545e
line too long again
peta78 Feb 24, 2022
a3bc6eb
improving style - visual indentation
peta78 Feb 24, 2022
4e39677
fixing test images - attempt
peta78 Feb 26, 2022
8f694e8
another test fixing
peta78 Feb 26, 2022
53aa569
I guess one more image test fix
peta78 Feb 26, 2022
c7129c0
I guess I am not done
peta78 Feb 26, 2022
5642dd3
this is getting interesting
peta78 Feb 26, 2022
e3a261b
this is getting interesting
peta78 Feb 26, 2022
10406e5
Merge branch 'tick3dfix' of https://github.com/pepe78/matplotlib into…
peta78 Feb 26, 2022
90fe98e
Merge branch 'matplotlib:main' into tick3dfix
peta78 Mar 1, 2022
37eb332
Merge branch 'matplotlib:main' into tick3dfix
peta78 Mar 1, 2022
3ced778
Merge branch 'tick3dfix' of https://github.com/pepe78/matplotlib into…
peta78 Mar 1, 2022
4cc3b57
Merge branch 'matplotlib:main' into tick3dfix
peta78 Mar 2, 2022
9a251d4
Merge branch 'matplotlib:main' into tick3dfix
peta78 Mar 2, 2022
a595e50
Merge branch 'tick3dfix' of https://github.com/pepe78/matplotlib into…
peta78 Mar 2, 2022
04f32eb
Merge branch 'matplotlib:main' into tick3dfix
peta78 Mar 2, 2022
4f9d36e
Merge branch 'tick3dfix' of https://github.com/pepe78/matplotlib into…
peta78 Mar 2, 2022
270a5bd
Merge branch 'tick3dfix' of https://github.com/pepe78/matplotlib into…
peta78 Mar 2, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 8 additions & 6 deletions lib/mpl_toolkits/mplot3d/axis3d.py
Original file line number Diff line number Diff line change
Expand Up @@ -420,13 +420,15 @@ def draw(self, renderer):
# Get tick line positions
pos = edgep1.copy()
pos[index] = tick.get_loc()
pos[tickdir] = (
edgep1[tickdir]
+ info['tick']['outward_factor'] * ticksign * tickdelta)
pos[tickdir] = edgep1[tickdir]
if tick._tickdir != 'out':
pos[tickdir] += (info['tick']['outward_factor']
* ticksign * tickdelta)
x1, y1, z1 = proj3d.proj_transform(*pos, self.axes.M)
pos[tickdir] = (
edgep1[tickdir]
- info['tick']['inward_factor'] * ticksign * tickdelta)
pos[tickdir] = edgep1[tickdir]
if tick._tickdir != 'in':
pos[tickdir] -= (info['tick']['inward_factor']
* ticksign * tickdelta)
x2, y2, z2 = proj3d.proj_transform(*pos, self.axes.M)

# Get position of label
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/axes3d_cla.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/bar3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/contour3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/contourf3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/errorbar3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/lines3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/minor_ticks.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/quiver3d.png
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/scatter3d.png
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/stem3d.png
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/surface3d.png
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/text3d.png
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/tricontour.png
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/trisurf3d.png
Binary file modified lib/mpl_toolkits/tests/baseline_images/test_mplot3d/voxels-xyz.png