Skip to content

Fix issue with manual clabel #22534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fix issue with manual clabel #22534

merged 1 commit into from
Feb 23, 2022
+1 −1

Conversation

oscargus
Copy link
Member

PR Summary

Closes #22532

Seemingly a leftover from name change/deprecation removal. I think it should go into 3.5.2.

Try the code in the issue to test it out.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: contour labels Feb 22, 2022
@oscargus oscargus added this to the v3.5.2 milestone Feb 22, 2022
@oscargus oscargus mentioned this pull request Feb 22, 2022
Closed
@carmaza
Copy link

carmaza commented Feb 22, 2022

This fixed #22532 for me. Thanks for the fast fix, @oscargus !

@timhoffm timhoffm merged commit 2b4b44e into matplotlib:main Feb 23, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 23, 2022
@timhoffm @meeseeksmachine
Backport PR matplotlib#22534: Fix issue with manual clabel
b3304d2
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 23, 2022
Merged
QuLogic added a commit that referenced this pull request Feb 23, 2022
@QuLogic
Merge pull request #22542 from meeseeksmachine/auto-backport-of-pr-22…
7e58197 
…534-on-v3.5.x

Backport PR #22534 on branch v3.5.x (Fix issue with manual clabel)
@oscargus oscargus deleted the fixmanualclabel branch February 23, 2022 10:53
@jklymak jklymak mentioned this pull request Apr 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: contour
Projects
None yet
Milestone
v3.5.2
Development

Successfully merging this pull request may close these issues.

[Issue]: Manually placing contour labels using clabel not working
4 participants
@oscargus @carmaza @anntzer @timhoffm