fix: fill stairs should have lw=0 instead of edgecolor="none" #22559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
approved these changes
Feb 26, 2022
|
@dstansby Yes, the new test fails without this PR |
|
👍🏻 to the change, I think this will lead to less surprise in multiple places (both the issue reported here and people passing I think this needs an API change note and should not be backported. I can be talked out of that position. |
|
@tacaswell Feels like a bugfix, the outward-facing interface is not changed, but I can add the change of behaviour w.r.t linewidth if desired |
f054e77 to
376d4d3
Compare
tacaswell
approved these changes
Mar 3, 2022
|
Thank you @andrzejnovak !! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 3, 2022
…ad of edgecolor="none"
QuLogic
added a commit
that referenced
this pull request
Mar 4, 2022
…559-on-v3.5.x Backport PR #22559 on branch v3.5.x (fix: fill stairs should have lw=0 instead of edgecolor="none")
|
Bug fix releases don't get What's new pages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
@jrueb has reported that calling
set_color()on existingstairs()that hadfillchanged the drawn object size. This is because currently forfill=Truestairsthe edge is "hidden" by settingedgecolor="none", whichset_color()overrides. This is not transparent. This PR changes the handling to instead set the edgelinewidthto 0. Test is included.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).