Clarify handling of #rrggbb(aa) colors in matplotlibrc. #22565
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
approved these changes
Feb 26, 2022
ghost
reviewed
Feb 26, 2022
lib/matplotlib/rcsetup.py
Outdated
| stmp = '#' + s | ||
| if is_color_like(stmp): | ||
| return stmp | ||
| # Support "rrggbb"/"rggbbaa" without leading '#' because these would be |
There was a problem hiding this comment.
rggbbaa -> rrggbbaa
it's just in comments, but...
There was a problem hiding this comment.
thanks for noting that, fixed.
The inconsistency is not that great, but let's at least document it.
|
We should consider whether this is the direction we want to go. Right now, the functionality is there, but likely almost nobody uses it because it's not documented. By documenting we encourage adoption. I'd rather not do that. Instead we should follow up on #19954, so that we can do |
|
No strong opinion there (other than my oft-stated opinion about the matplotlibrc syntax in general). |
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Mar 3, 2022
This enables using the comment character # within strings. Closes matplotlib#19288. Superseeds matplotlib#22565.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Mar 4, 2022
This enables using the comment character # within strings. Closes matplotlib#19288. Superseeds matplotlib#22565.
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Mar 4, 2022
This enables using the comment character # within strings. Closes matplotlib#19288. Superseeds matplotlib#22565.
|
Superseeded by #22589. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inconsistency is not that great, but let's at least document it.
See https://discourse.matplotlib.org/t/specifying-hex-colors-in-style-sheets/22624.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).