Skip to content

Rename qhull source to _qhull_wrapper.cpp. #22568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 26, 2022

This is consistent with all other extension modules, which are named
<modulename>_wrapper.cpp.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

This is consistent with all other extension modules, which are named
`<modulename>_wrapper.cpp`.
@tacaswell tacaswell added this to the v3.6.0 milestone Feb 28, 2022
@oscargus oscargus merged commit c8dc379 into matplotlib:main Feb 28, 2022
@anntzer anntzer deleted the qw branch February 28, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants