Fix issue with unhandled Done exception #22572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on https://groups.google.com/g/wx-users/c/i0lWE_BsbTw?pli=1 👍🏻 that this is the right API to use here (we should opt to being as lazy as possible and letting the GUI idle loop take care of actually re-paint). |
tacaswell
approved these changes
Feb 28, 2022
QuLogic
approved these changes
Mar 1, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 1, 2022
tacaswell
added a commit
that referenced
this pull request
Mar 1, 2022
…572-on-v3.5.x Backport PR #22572 on branch v3.5.x (Fix issue with unhandled Done exception)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #21798
The solution was given, but I thought it makes sense to get it into the code base as well... I can confirm from manual tests that it does solve the problem (as in that it doesn't happen, if it breaks anything else remains to see, but nothing I have seen yet).
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).