Support quoted strings in matplotlibrc #22589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
reviewed
Mar 3, 2022
|
I guess it's OK to not support single quotes or backslash escapes (I'm less sure wrt double quotes in the string, which seem unsupported too?), but the difference with standard python syntax should probably be explicitly noted. |
|
I am 👍🏻 on this in principle, but something seems wrong with the rcparams parsing. |
88b4a0d to
fc41ba4
Compare
|
Ha! Edge case when the line starts with a comment. Tests should pass now. |
I indeed plan to supporting backslash escapes soon. |
This enables using the comment character # within strings. Closes matplotlib#19288. Superseeds matplotlib#22565.
fc41ba4 to
7c378a8
Compare
tacaswell
approved these changes
Mar 6, 2022
oscargus
approved these changes
Mar 6, 2022
6 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables using the comment character # within strings. Also it lets you write hex colors more consistently as "#FFFFFF" rather than FFFFFF (i.e. omitting the hash). We discourage the latter but keep it for backward compatibility.
Closes #19288.
Superseeds #22565.