Raise on missing closing quotes in matplotlibrc #22668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa365ca to
89eb2d1
Compare
tacaswell
approved these changes
Mar 18, 2022
|
Are we sure we have no legitimate value which will have one |
|
Single This is e.g. also the behavior in YAML, which supports quoted and unquoted strings. |
|
Should the error message say that? (Espace single "). |
oscargus
approved these changes
Mar 20, 2022
89eb2d1 to
c44ebd7
Compare
|
Added a note on escaping to the exception message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #22636.