Skip to content

Use repr in error messages #22712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2022
Merged

Use repr in error messages #22712

merged 1 commit into from
Apr 7, 2022

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Mar 27, 2022 •
edited
Loading

PR Summary

Related to #21959

Added tests for some of the errors.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus marked this pull request as draft March 28, 2022 06:08
@oscargus oscargus force-pushed the reprinerrors branch 5 times, most recently from 2c8c6c9 to 985c73d Compare March 28, 2022 11:19
@oscargus oscargus marked this pull request as ready for review March 28, 2022 11:34
@oscargus oscargus mentioned this pull request Mar 29, 2022
Merged
6 tasks
@oscargus oscargus force-pushed the reprinerrors branch 2 times, most recently from 3e617ff to 498f462 Compare March 30, 2022 07:33
timhoffm
timhoffm reviewed Mar 30, 2022
View reviewed changes
@oscargus oscargus added this to the v3.6.0 milestone Apr 4, 2022
@matplotlib matplotlib deleted a comment from oscargus Apr 5, 2022
@QuLogic
Copy link
Member

QuLogic commented Apr 5, 2022 •
edited
Loading

@QuLogic QuLogic deleted a comment from oscargus 30 seconds ago

Wait, what? I thought I was deleting a pending comment of mine. I don't know what got deleted now.

@QuLogic QuLogic closed this Apr 5, 2022
@QuLogic QuLogic reopened this Apr 5, 2022
@timhoffm
Copy link
Member

timhoffm commented Apr 7, 2022 •
edited
Loading

We'll never know what got deleted ... 🪄

Still this PR looks fine, so I merge as is.

@timhoffm timhoffm merged commit 0e46ff2 into matplotlib:main Apr 7, 2022
@oscargus oscargus deleted the reprinerrors branch April 7, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oscargus @QuLogic @timhoffm