Small style fixes. #22721
Merged
Small style fixes. #22721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Mar 28, 2022
| Affine2D() | ||
| .scale(1.0, -1.0) | ||
| .translate(0.0, self.height)) | ||
| return transform + Affine2D().scale(1, -1).translate(0, self.height) |
There was a problem hiding this comment.
The multi-line version is arguably more readable but not going to block over that.
tacaswell
approved these changes
Mar 28, 2022
timhoffm
approved these changes
Mar 29, 2022
| Affine2D() | ||
| .scale(1.0, -1.0) | ||
| .translate(0.0, self.height)) | ||
| return transform + Affine2D().scale(1, -1).translate(0, self.height) |
|
@tacaswell you‘re milestoneing this as 3.7. have we already branched of 3.6? |
oscargus
reviewed
Mar 29, 2022
oscargus
reviewed
Mar 29, 2022
|
We have not yet branched 3.6 off from main, so the canoncial target is 3.6.0. |
|
I miss-clicked, but I did make the 3.7 milestone for stuff we know we want to push out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).