Move towards making texmanager stateless. #22725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest to make all stateless functions classmethods to make it very clear that they do not depend on state. |
|
Good idea, done. |
timhoffm
reviewed
Mar 29, 2022
| for font_family in cls._font_families: | ||
| if is_reduced_font and font_family == requested_family: | ||
| preambles[font_family] = cls._font_preambles[ | ||
| rcParams['font.family'][0].lower()] |
There was a problem hiding this comment.
Um, what is this? I thought rcParams['font.family'] is a string?!? Should this be
Suggested change
| rcParams['font.family'][0].lower()] | |
| rcParams['font.family'].lower()] |
There was a problem hiding this comment.
No, it's a list of strings:
matplotlib/lib/matplotlib/rcsetup.py
Line 914 in f670fe7
There was a problem hiding this comment.
Ah, I was checking
and
We should make that clearer in matplotlibrc.
And yes interestingly validate_stringlist can make a list out of a single string. matplotlibrc is less well-defined than I thought 😦.
There was a problem hiding this comment.
This could reasonably be tracked as a separate issue?
Previously, TexManager needed to call get_font_config at a specific place in the middle of processing to update some internal attributes before proceeding with TeX source generation. Instead, move towards making TexManager stateless (except for caching), i.e. the user facing API should be thought of as a bunch of independently callable functions `make_tex()`, `make_dvi()`, etc. (they will probably stay as methods on a "empty" TexManager object for a long time for backcompat, in fact).
oscargus
approved these changes
Mar 31, 2022
timhoffm
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, TexManager needed to call get_font_config at a specific
place in the middle of processing to update some internal attributes
before proceeding with TeX source generation. Instead, move towards
making TexManager stateless (except for caching), i.e. the user facing
API should be thought of as a bunch of independently callable functions
make_tex(),make_dvi(), etc. (they will probably stay as methods ona "empty" TexManager object for a long time for backcompat, in fact).
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).